Skip to content

Commit d51ddc6

Browse files
authored
upgrade to opentelemetry API/SDK 0.16b1 (#93)
1 parent c3772de commit d51ddc6

4 files changed

Lines changed: 25 additions & 23 deletions

File tree

dev-constraints.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ Sphinx==3.1.2
1010
# development before GA. After GA, we will build against specific releases.
1111
# Bump the commit frequently during development whenever you are missing
1212
# changes from upstream.
13-
opentelemetry-api~=0.15b0
14-
opentelemetry-sdk~=0.15b0
13+
opentelemetry-api~=0.16b1
14+
opentelemetry-sdk~=0.16b1

opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_monitoring/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from google.cloud.monitoring_v3.proto.metric_pb2 import TimeSeries
1212
from opentelemetry.sdk.metrics import UpDownCounter
1313
from opentelemetry.sdk.metrics.export import (
14-
MetricRecord,
14+
ExportRecord,
1515
MetricsExporter,
1616
MetricsExportResult,
1717
)
@@ -135,7 +135,7 @@ def _batch_write(self, series: TimeSeries) -> None:
135135
write_ind += MAX_BATCH_WRITE
136136

137137
def _get_metric_descriptor(
138-
self, record: MetricRecord
138+
self, record: ExportRecord
139139
) -> Optional[MetricDescriptor]:
140140
""" We can map Metric to MetricDescriptor using Metric.name or
141141
MetricDescriptor.type. We create the MetricDescriptor if it doesn't
@@ -273,10 +273,10 @@ def _set_start_end_times(self, point_dict, record, metric_descriptor):
273273
}
274274

275275
def export(
276-
self, metric_records: Sequence[MetricRecord]
276+
self, export_records: Sequence[ExportRecord]
277277
) -> "MetricsExportResult":
278278
all_series = []
279-
for record in metric_records:
279+
for record in export_records:
280280
instrument = record.instrument
281281
metric_descriptor = self._get_metric_descriptor(record)
282282
if not metric_descriptor:

opentelemetry-exporter-google-cloud/tests/test_cloud_monitoring.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
CloudMonitoringMetricsExporter,
3131
)
3232
from opentelemetry.sdk.metrics import MeterProvider
33-
from opentelemetry.sdk.metrics.export import MetricRecord
33+
from opentelemetry.sdk.metrics.export import ExportRecord
3434
from opentelemetry.sdk.metrics.export.aggregate import (
3535
HistogramAggregator,
3636
SumAggregator,
@@ -145,7 +145,7 @@ def test_get_metric_descriptor(self):
145145

146146
self.assertIsNone(
147147
exporter._get_metric_descriptor(
148-
MetricRecord(
148+
ExportRecord(
149149
MockMetric(),
150150
(),
151151
UnsupportedAggregator(),
@@ -154,7 +154,7 @@ def test_get_metric_descriptor(self):
154154
)
155155
)
156156

157-
record = MetricRecord(
157+
record = ExportRecord(
158158
MockMetric(),
159159
(("label1", "value1"),),
160160
SumAggregator(),
@@ -185,7 +185,7 @@ def test_get_metric_descriptor(self):
185185

186186
# Drop labels with values that aren't string, int or bool
187187
exporter._get_metric_descriptor(
188-
MetricRecord(
188+
ExportRecord(
189189
MockMetric(name="name2", value_type=float),
190190
(
191191
("label1", "value1"),
@@ -222,7 +222,7 @@ def test_get_value_observer_metric_descriptor(self):
222222
project_id=self.project_id, client=client
223223
)
224224
exporter.project_name = self.project_name
225-
record = MetricRecord(
225+
record = ExportRecord(
226226
MockMetric(),
227227
(),
228228
ValueObserverAggregator(),
@@ -259,7 +259,7 @@ def test_export(self):
259259

260260
exporter.export(
261261
[
262-
MetricRecord(
262+
ExportRecord(
263263
MockMetric(),
264264
(("label1", "value1"),),
265265
UnsupportedAggregator(),
@@ -303,13 +303,13 @@ def test_export(self):
303303
) * NANOS_PER_SECOND
304304
exporter.export(
305305
[
306-
MetricRecord(
306+
ExportRecord(
307307
MockMetric(meter=mock_meter()),
308308
(("label1", "value1"), ("label2", 1),),
309309
sum_agg_one,
310310
resource,
311311
),
312-
MetricRecord(
312+
ExportRecord(
313313
MockMetric(meter=mock_meter()),
314314
(("label1", "value2"), ("label2", 2),),
315315
sum_agg_one,
@@ -360,13 +360,13 @@ def test_export(self):
360360
) * NANOS_PER_SECOND
361361
exporter.export(
362362
[
363-
MetricRecord(
363+
ExportRecord(
364364
MockMetric(),
365365
(("label1", "value1"), ("label2", 1),),
366366
sum_agg_two,
367367
Resource.create_empty(),
368368
),
369-
MetricRecord(
369+
ExportRecord(
370370
MockMetric(),
371371
(("label1", "value2"), ("label2", 2),),
372372
sum_agg_two,
@@ -380,7 +380,7 @@ def test_export(self):
380380
sum_agg_two.checkpoint = 2
381381
exporter.export(
382382
[
383-
MetricRecord(
383+
ExportRecord(
384384
MockMetric(),
385385
(("label1", "changed_label"), ("label2", 2),),
386386
sum_agg_two,
@@ -439,7 +439,7 @@ def test_export_value_observer(self):
439439
) * NANOS_PER_SECOND
440440
exporter.export(
441441
[
442-
MetricRecord(
442+
ExportRecord(
443443
MockMetric(meter=mock_meter()),
444444
(),
445445
aggregator,
@@ -493,7 +493,7 @@ def test_export_histogram(self):
493493
) * NANOS_PER_SECOND
494494
exporter.export(
495495
[
496-
MetricRecord(
496+
ExportRecord(
497497
MockMetric(meter=mock_meter()),
498498
(),
499499
aggregator,
@@ -555,7 +555,7 @@ def test_stateless_times(self):
555555
agg.checkpoint = 1
556556
agg.last_update_timestamp = (WRITE_INTERVAL + 1) * NANOS_PER_SECOND
557557

558-
metric_record = MetricRecord(
558+
metric_record = ExportRecord(
559559
MockMetric(stateful=False), (), agg, Resource.create_empty()
560560
)
561561

@@ -578,7 +578,7 @@ def test_stateless_times(self):
578578

579579
agg.last_update_timestamp = (WRITE_INTERVAL * 2 + 2) * NANOS_PER_SECOND
580580

581-
metric_record = MetricRecord(
581+
metric_record = ExportRecord(
582582
MockMetric(stateful=False), (), agg, Resource.create_empty()
583583
)
584584

@@ -633,7 +633,7 @@ def test_unique_identifier(self):
633633

634634
sum_agg_one = SumAggregator()
635635
sum_agg_one.update(1)
636-
metric_record = MetricRecord(
636+
metric_record = ExportRecord(
637637
MockMetric(), (), sum_agg_one, Resource.create_empty()
638638
)
639639
exporter1.export([metric_record])

tox.ini

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ whitelist_externals = bash
8383
; for development, run `tox -e dev`. To run fixers (black, isort) `tox -e fix`.
8484
; Lint is run as part of CI as well, so uses a separate.
8585
[testenv:{dev,docs,fix,lint,mypy}]
86+
download = true
8687
basepython = {[constants]dev_basepython}
8788
envdir = venv
8889

@@ -102,9 +103,10 @@ whitelist_externals =
102103
bash
103104

104105
[testenv:{docs,lint,mypy}-ci]
106+
download = true
105107
basepython = {[constants]dev_basepython}
106108
deps =
107-
{[constants]dev_deps}
109+
!docs: {[constants]dev_deps}
108110
docs: {[constants]docs_deps}
109111

110112
commands =

0 commit comments

Comments
 (0)