Skip to content

Use LogRecord.event_name to set the log ID when the gcp log name attribute is not present.#417

Merged
DylanRussell merged 12 commits intoGoogleCloudPlatform:mainfrom
DylanRussell:logname_change
Oct 6, 2025
Merged

Use LogRecord.event_name to set the log ID when the gcp log name attribute is not present.#417
DylanRussell merged 12 commits intoGoogleCloudPlatform:mainfrom
DylanRussell:logname_change

Conversation

@DylanRussell
Copy link
Copy Markdown
Contributor

No description provided.

@DylanRussell DylanRussell requested a review from a team as a code owner July 15, 2025 18:16
@quentinmit
Copy link
Copy Markdown
Member

What is the spec for event_name? I wouldn't expect it to be the right grouping for a log name. (A better fit is probably the scope name, for instance.)

@DylanRussell
Copy link
Copy Markdown
Contributor Author

event name is what makes a log an event : https://opentelemetry.io/docs/specs/otel/logs/data-model/#field-eventname -- why not use it for log name ? We want gen ai events to be easily selected based on the log name drop down in the logs explorer, that's what is motivating this change.. We agreed on this internally, probably better to discuss it there

Comment thread opentelemetry-exporter-gcp-logging/setup.cfg
@DylanRussell DylanRussell enabled auto-merge (squash) October 3, 2025 17:05
@DylanRussell
Copy link
Copy Markdown
Contributor Author

/gcbrun

@DylanRussell DylanRussell merged commit 837543f into GoogleCloudPlatform:main Oct 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants