Update adk sample to use --otel_to_cloud instead of custom main.py#446
Merged
aabmass merged 1 commit intoGoogleCloudPlatform:mainfrom Nov 4, 2025
Merged
Conversation
aabmass
force-pushed
the
update-adk-otel-to-cloud
branch
from
37b861d to
6cf35a0
Compare
aabmass
commented
Nov 4, 2025
| # For this example this would be the current directory containing main.py. | ||
| # Note: Calling this method attempts to set the global tracer provider, which has already been | ||
| # set by the setup_opentelemetry() function. | ||
| app = get_fast_api_app( |
Collaborator
Author
There was a problem hiding this comment.
This whole custom driver main.py is no longer needed so I deleted it. --otel_to_cloud handles it all.
Alternatively, we could leave this boilerplate and pass get_fast_api_app(..., otel_to_cloud=True) and keep some boilerplate if it's easier for snippets.
|
Here is the summary of changes. You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
DylanRussell
approved these changes
Nov 4, 2025
aabmass
force-pushed
the
update-adk-otel-to-cloud
branch
from
6cf35a0 to
68327a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.