services: fix timed? and keep_alive? return type to T::Boolean

Library/Homebrew/services/formula_wrapper.rb

@@ -50,17 +50,21 @@ def service?
       end
 
       # Delegate access to `formula.service.timed?`.
-      # TODO: this should either be T::Boolean or renamed to `timed`
-      sig { returns(T.nilable(T::Boolean)) }
+      sig { returns(T::Boolean) }
       def timed?
-        @timed ||= T.let((load_service.timed? if service?), T.nilable(T::Boolean))
+        return @timed unless @timed.nil?
+
+        @timed = T.let(service? && load_service.timed?, T.nilable(T::Boolean))
+        T.must(@timed)
       end
 
       # Delegate access to `formula.service.keep_alive?`.
-      # TODO: this should either be T::Boolean or renamed to `keep_alive`
-      sig { returns(T.nilable(T::Boolean)) }
+      sig { returns(T::Boolean) }
       def keep_alive?
-        @keep_alive ||= T.let((load_service.keep_alive? if service?), T.nilable(T::Boolean))
+        return @keep_alive unless @keep_alive.nil?
+
+        @keep_alive = T.let(service? && load_service.keep_alive?, T.nilable(T::Boolean))
+        T.must(@keep_alive)
       end
 
       # service_name delegates with formula.plist_name or formula.service_name

Library/Homebrew/test/services/formula_wrapper_spec.rb

@@ -324,10 +324,10 @@
       expect(service.timed?).to be(false)
     end
 
-    it "returns nil if no service" do
+    it "returns false if no service" do
       allow(service).to receive(:service?).once.and_return(false)
 
-      expect(service.timed?).to be_nil
+      expect(service.timed?).to be(false)
     end
   end
 
@@ -350,10 +350,10 @@
       expect(service.keep_alive?).to be(false)
     end
 
-    it "returns nil if no service" do
+    it "returns false if no service" do
       allow(service).to receive(:service?).once.and_return(false)
 
-      expect(service.keep_alive?).to be_nil
+      expect(service.keep_alive?).to be(false)
     end
   end
 
@@ -383,7 +383,7 @@
         pid:          nil,
         registered:   false,
         running:      false,
-        schedulable:  nil,
+        schedulable:  false,
         service_name: "plist-mysql-test",
         status:       :none,
         user:         nil,
@@ -405,7 +405,7 @@
         pid:          nil,
         registered:   true,
         running:      false,
-        schedulable:  nil,
+        schedulable:  false,
         service_name: "plist-mysql-test",
         status:       :none,
         user:         nil,