fix(*): add mustCoerceToInt to relevant props - 21.1.x#17191
Open
IMinchev64 wants to merge 2 commits into21.1.xfrom
Open
fix(*): add mustCoerceToInt to relevant props - 21.1.x#17191IMinchev64 wants to merge 2 commits into21.1.xfrom
IMinchev64 wants to merge 2 commits into21.1.xfrom
Conversation
IMinchev64
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Blazor-facing metadata hints (/* mustCoerceToInt */) to selected enum-typed properties so generated metadata resolves enum values as numbers (instead of strings) for Blazor consumption.
Changes:
- Annotate
IDimensionsChange.dimensionCollectionType(pivot grid) for numeric enum coercion in metadata. - Annotate
IPinningConfig.columns/rows(grid pinning) for numeric enum coercion in metadata. - Annotate
PositionSettingsalignment properties and filtering tree enum properties for numeric enum coercion in metadata.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/core/src/pivot-grid.interface.ts | Adds mustCoerceToInt to the pivot dimension-collection type in IDimensionsChange. |
| projects/igniteui-angular/grids/core/src/common/grid.interface.ts | Adds mustCoerceToInt to pinning config enum properties (columns, rows). |
| projects/igniteui-angular/core/src/services/overlay/utilities.ts | Adds mustCoerceToInt to overlay positioning alignment enum properties in PositionSettings. |
| projects/igniteui-angular/core/src/data-operations/filtering-expressions-tree.ts | Adds mustCoerceToInt to filtering tree enum properties (operator, type). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute is needed so the metadata descriptions which are used by Blazor can be updated which would resolve the enum values as numbers instead of strings.
Related to: https://infragistics.visualstudio.com/Indigo_Platform/_workitems/edit/34678
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)