Skip to content

Add local dotnet tool manifest for EF and trx-to-vsplaylist and validate EF migrations in CI #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminMichaelis merged 2 commits into from
Apr 25, 2026
Merged

Add local dotnet tool manifest for EF and trx-to-vsplaylist and validate EF migrations in CI #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
923ff8e
Add local dotnet tool manifest
Copilot Apr 25, 2026
3886338
Add EF migration drift check to PR workflow
Copilot Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"version": 1,
"isRoot": true,
"tools": {
"dotnet-ef": {
"version": "10.0.7",
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest pins dotnet-ef to 10.0.7, but the web project references Microsoft.EntityFrameworkCore.Tools 10.0.6 (see Directory.Packages.props). EF tooling is sensitive to version mismatches; consider aligning these versions (either bump the package to 10.0.7 or pin the tool to 10.0.6) to avoid CLI/runtime incompatibilities.

Suggested change
"version": "10.0.7",
"version": "10.0.6",

Copilot uses AI. Check for mistakes.
"commands": [
"dotnet-ef"
],
"rollForward": false
},
"trx-to-vsplaylist": {
"version": "1.3.0",
"commands": [
"trx-to-vsplaylist"
],
"rollForward": false
}
}
}
8 changes: 8 additions & 0 deletions .github/workflows/PR-Build-And-Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,17 @@ jobs:
- name: Restore with dotnet
run: dotnet restore /p:AccessToNugetFeed=false

- name: Restore local dotnet tools
run: dotnet tool restore

- name: Build with dotnet
run: dotnet build --configuration Release --no-restore /p:AccessToNugetFeed=false

- name: Check for pending EF Core model changes
run: dotnet ef migrations has-pending-model-changes --project EssentialCSharp.Web --configuration Release --no-build
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet tool restore installs dotnet-ef as a local tool, but this step calls dotnet ef ..., which typically relies on dotnet-ef being discoverable as a CLI extension on PATH (often via a global tool install). To ensure CI uses the restored local tool and doesn’t depend on runner/global state, invoke it via dotnet tool run dotnet-ef -- migrations has-pending-model-changes ... (or otherwise ensure the local tool is on PATH).

Suggested change
run: dotnet ef migrations has-pending-model-changes --project EssentialCSharp.Web --configuration Release --no-build
run: dotnet tool run dotnet-ef -- migrations has-pending-model-changes --project EssentialCSharp.Web --configuration Release --no-build

Copilot uses AI. Check for mistakes.
env:
ASPNETCORE_ENVIRONMENT: Development

- name: Expose GitHub Actions Runtime
uses: actions/github-script@v9
with:
Expand Down
Loading