Upgrade to .NET 10.0 and update NuGet packages #823
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -16,22 +16,33 @@ protected override void ConfigureWebHost(IWebHostBuilder builder) | |||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||
| builder.ConfigureServices(services => | ||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||
| // Remove the existing DbContext and related services | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The comment on line 19 mentions "Remove the existing DbContext and related services" but the code only removes a single service descriptor (lines 20-25). The broader removal happens in the subsequent block (lines 27-34). Consider moving this comment to line 27 or updating it to clarify that this first block only removes the primary DbContext service.
Suggested change
|
||||||||||||||||||||||||||||||
| var descriptorType = typeof(DbContextOptions<EssentialCSharpWebContext>); | ||||||||||||||||||||||||||||||
| var descriptor = services.SingleOrDefault(d => d.ServiceType == descriptorType); | ||||||||||||||||||||||||||||||
| if (descriptor != null) | ||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||
| services.Remove(descriptor); | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| // Remove all DbContextOptions related services to avoid EF Core 10 multiple provider error | ||||||||||||||||||||||||||||||
| var allDbContextOptions = services.Where(d => | ||||||||||||||||||||||||||||||
| d.ServiceType.IsGenericType && | ||||||||||||||||||||||||||||||
| d.ServiceType.Name.Contains("DbContextOptions")).ToList(); | ||||||||||||||||||||||||||||||
| foreach (var desc in allDbContextOptions) | ||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||
| services.Remove(desc); | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
Comment on lines
+28
to
+34
There was a problem hiding this comment. The filtering logic using |
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| _Connection = new SqliteConnection(SqlConnectionString); | ||||||||||||||||||||||||||||||
| _Connection.Open(); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| // Add SQLite DbContext without using the global service provider | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The comment states "Add SQLite DbContext without using the global service provider" but the code in lines 47-52 still uses |
||||||||||||||||||||||||||||||
| services.AddDbContext<EssentialCSharpWebContext>(options => | ||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||
| options.UseSqlite(_Connection); | ||||||||||||||||||||||||||||||
| // Disable service provider caching to avoid shared state in EF Core 10 | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The comment states "Disable service provider caching to avoid shared state in EF Core 10" but doesn't explain why this is necessary or the implications. Consider expanding this comment to explain the specific EF Core 10 behavior change that necessitates this workaround, and any potential performance impact of disabling caching.
Suggested change
|
||||||||||||||||||||||||||||||
| options.EnableServiceProviderCaching(false); | ||||||||||||||||||||||||||||||
| }, ServiceLifetime.Scoped, ServiceLifetime.Scoped); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| using ServiceProvider serviceProvider = services.BuildServiceProvider(); | ||||||||||||||||||||||||||||||
| using IServiceScope scope = serviceProvider.CreateScope(); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "10.0.100", | ||
| "rollForward": "latestMinor" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do we need these changes?
And also the changes in WebApplicationFactory.cs? Can we just make sure we only have minimal changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
WarningsNotAsErrorsin Directory.Build.props is necessary because:NU1902/NU1903: .NET 10 introduced stricter NuGet audit that treats transitive package vulnerabilities as errors when
TreatWarningsAsErrorsis enabled. These vulnerabilities are in old design-time dependencies (Microsoft.AspNetCore.Mvc 1.0.3) pulled in by Microsoft.VisualStudio.Web.CodeGeneration.Design 10.0-rc.1. Without this,dotnet restorefails.CA1873: New .NET 10 analyzer with 21 instances across the codebase for logging performance. Without suppression,
dotnet buildfails.The WebApplicationFactory changes are necessary for EF Core 10 - without
EnableServiceProviderCaching(false), tests fail with "multiple database providers registered" error.Options:
Which approach would you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade the package to recent enough that it is compatible and doesn't have transitive vulnerabilities? @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially resolved in 0924c9b. I removed Microsoft.VisualStudio.Web.CodeGeneration.Design (RC version) which was only needed for scaffolding and reduced some vulnerabilities.
However, the remaining NU1902/NU1903 warnings are from Microsoft.AspNetCore.Mvc.Testing 10.0.0 (stable, not RC). This Microsoft package has transitive dependencies on old Microsoft.AspNetCore.Mvc 1.0.3 packages with known vulnerabilities. This is a Microsoft package issue, not something we can upgrade - we're already using the latest stable version (10.0.0).
The WarningsNotAsErrors for NU1902/NU1903 is still necessary to prevent build failures from these Microsoft package issues. The WebApplicationFactory changes are also still necessary for EF Core 10 compatibility.