Add a CI job that runs ExplicitImports, and fix existing implicit imports

.github/workflows/CI.yml

@@ -60,3 +60,33 @@ jobs:
           using WebCacheUtilities
 
           Aqua.test_all(WebCacheUtilities; stale_deps=false, deps_compat=false)
+
+  explicit-imports:
+    name: Julia ${{ matrix.version }} - ExplicitImports
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        version:
+          - '1'
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - uses: julia-actions/setup-julia@v2
+        with:
+          version: ${{ matrix.version }}
+      - uses: julia-actions/cache@v2
+      - name: Run ExplicitImports.jl
+        shell: julia --color=yes {0}
+        run: |
+          import Pkg
+          Pkg.activate(; temp=true)
+          Pkg.develop(Pkg.PackageSpec(path=pwd()))
+          Pkg.add("ExplicitImports")
+          Pkg.instantiate()
+
+          using ExplicitImports
+          using WebCacheUtilities
+
+          check_no_implicit_imports(WebCacheUtilities)

src/CSVAnalysis.jl

@@ -1,4 +1,5 @@
-using CSV, DataFrames
+using CSV: CSV
+using DataFrames: DataFrames, DataFrame
 
 export parse_csv_source_ips, parse_csv_payload_sizes, parse_csv_http_uri, parse_csv_http_method, parse_csv_http_response_code,
        attribute_data_to_providers, find_provider
@@ -104,4 +105,4 @@ function attribute_data_to_providers(ip_traffic::Dict, pxs::Dict{String,Vector{<
         provider_traffic[find_provider(prefix_dict, ip)] += traffic
     end
     return provider_traffic
-end
+end

src/Fastly.jl

@@ -1,5 +1,6 @@
 module Fastly
-using HTTP, JSON
+using HTTP: HTTP
+using JSON: JSON
 import ..IPSubnet
 
 export get_mutable_service_version

src/WebCacheUtilities.jl

@@ -1,5 +1,12 @@
 module WebCacheUtilities
-using JSON, HTTP, Sockets
+using AbstractTrees: AbstractTrees, PostOrderDFS
+using CSV: CSV
+using DataFrames: DataFrames, DataFrame
+using Dates: DateTime, Hour, Second, TimePeriod
+using Gumbo: Gumbo, HTMLElement, parsehtml, tag
+using HTTP: HTTP
+using JSON: JSON
+using Sockets: Sockets, IPAddr, IPv4, IPv6
 
 include("file_cache.jl")
 include("IPSubnet.jl")

src/graylog.jl

@@ -1,4 +1,8 @@
-using HTTP, Dates, JSON
+using CSV: CSV
+using DataFrames: DataFrame
+using Dates: DateTime, Hour, Second, TimePeriod
+using HTTP: HTTP
+using JSON: JSON
 
 export get_graylog_csv, parse_message
 

src/ipinfo.jl

@@ -1,4 +1,5 @@
-using Gumbo, AbstractTrees
+using AbstractTrees: AbstractTrees, PostOrderDFS
+using Gumbo: Gumbo, HTMLElement, parsehtml, tag
 
 function for_each_href(f::Function, html_path::AbstractString)
     html = parsehtml(String(read(html_path)))
@@ -52,4 +53,4 @@ function dig_cache(domain, record_type="A")
         end
     end
     return readlines(record_file)
-end
+end

src/providers/AWS.jl

@@ -1,5 +1,5 @@
 module AWS
-using HTTP, JSON
+using JSON: JSON
 import ..IPSubnet, ..download_to_cache
 
 prefixes_by_region = Dict{String,Vector{IPSubnet}}()
@@ -35,4 +35,4 @@ function prefix_regions()
     return collect(keys(prefixes_by_region))
 end
 
-end # AWS
+end # AWS

src/providers/Azure.jl

@@ -1,5 +1,5 @@
 module Azure
-using HTTP, JSON, Gumbo, AbstractTrees
+using JSON: JSON
 import ..IPSubnet, ..download_to_cache, ..for_each_href
 
 prefixes_by_region = Dict{String,Vector{IPSubnet}}()
@@ -48,4 +48,4 @@ function prefix_regions()
     return collect(keys(prefixes_by_region))
 end
 
-end # module Azure
+end # module Azure