Skip to content

Allow generic arrays, not just vectors#167

Merged
gdalle merged 4 commits intomainfrom
gd/arrays
Apr 15, 2025
Merged

Allow generic arrays, not just vectors#167
gdalle merged 4 commits intomainfrom
gd/arrays

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Apr 15, 2025

Relax constraints on x and y to accept arbitrary arrays. This is done using a wrapper VecToVec which takes an array-to-array function and turns it into a vector-to-vector equivalent.

It is very important however that the conditions output c has the same size as y, at least for the time being. Pad it with zeros if necessary.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
ext/ImplicitDifferentiationChainRulesCoreExt.jl 94.73% <100.00%> (+0.61%) ⬆️
ext/ImplicitDifferentiationForwardDiffExt.jl 100.00% <100.00%> (ø)
src/ImplicitDifferentiation.jl 100.00% <ø> (ø)
src/execution.jl 100.00% <100.00%> (ø)
src/implicit_function.jl 88.00% <100.00%> (ø)
src/preparation.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as ready for review April 15, 2025 11:12
@gdalle gdalle merged commit da2c944 into main Apr 15, 2025
4 checks passed
@gdalle gdalle deleted the gd/arrays branch May 3, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant