You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LinearMaps also works with Krylov.jl. What is the reason to support IterativeSolvers.jl? For information, the GMRES method is only restarted in this package.
To me it made sense to support both ecosystems: LinearMaps + IterativeSolvers and LinearOperators + Krylov, since they were both designed to work best with each other.
To the best of my knowledge, Krylov.jl was modified since a few years to work with both API the same way.
Be careful if you use solvers IterativeSolvers, a few of their solvers have bugs... SciML/LinearSolve.jl#181
Essentially my reasoning was: due to some type issues, I sometimes need LinearMaps instead of LinearOperators. In that case, I should pick the solver that goes best with LinearMaps, and I thought that was IterativeSolvers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Breaking changes in the public API. Bumping version to v0.8.0.
Breaking changes
KrylovLinearSolverintoIterativeLinearSolverstrictbehavior with DifferentiationInterface, with an option to relax itLinearOperatordefinition, leading to errors with ComponentArraysBa function instead of a linear operator or matrixOther changes
conditionswith respect toxandyInternal changes