Skip to content

fix: ignore input type in LinearOperator construction by default#174

Merged
gdalle merged 2 commits intomainfrom
gd/linop
Jun 14, 2025
Merged

fix: ignore input type in LinearOperator construction by default#174
gdalle merged 2 commits intomainfrom
gd/linop

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Jun 14, 2025

  • By default, create the LinearOperator associated with A without providing S = typeof(input). Specifying S requires S(undef, n) to be defined, which is false for many custom vector types. Instead, we keep the default fallback on S=Vector, which is more likely to work.
  • Add a keep_input_type keyword argument to OperatorRepresentation in order to allow the old behavior if necessary, e.g. on GPU. This does nothing for FunctionMap.
  • Add a posdef argument to OperatorRepresentation, which FunctionMap can take advantage of. This does nothing for LinearOperator.
  • Specify that the kwargs of IterativeLinearSolver{:Krylov} might be passed to gmres or block_gmres

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/execution.jl 100.00% <ø> (ø)
src/settings.jl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle merged commit b75add5 into main Jun 14, 2025
4 checks passed
@gdalle gdalle deleted the gd/linop branch June 14, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant