Skip to content

Revert "test: use ChainRulesTestUtils" #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdalle merged 1 commit into from
Jun 15, 2025
Merged

Revert "test: use ChainRulesTestUtils" #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ext/ImplicitDifferentiationChainRulesCoreExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ using ImplicitDifferentiation:
ImplicitDifferentiation.chainrules_suggested_backend(rc::RuleConfig) = AutoChainRules(rc)

function ChainRulesCore.rrule(
rc::RuleConfig, implicit::ImplicitFunction, x::AbstractArray, args::Vararg{Any,N}
rc::RuleConfig, implicit::ImplicitFunction, x::AbstractArray, args::Vararg{Any,N};
) where {N}
(; conditions, linear_solver) = implicit
y, z = implicit(x, args...)
c = conditions(x, y, z, args...)
c = implicit.conditions(x, y, z, args...)

suggested_backend = chainrules_suggested_backend(rc)
Aᵀ = build_Aᵀ(implicit, x, y, z, c, args...; suggested_backend)
Expand All @@ -28,11 +27,11 @@ function ChainRulesCore.rrule(
function implicit_pullback((dy, dz))
dy = unthunk(dy)
dy_vec = vec(dy)
dc_vec = linear_solver(Aᵀ, -dy_vec)
dc_vec = implicit.linear_solver(Aᵀ, -dy_vec)
dx_vec = Bᵀ(dc_vec)
dx = reshape(dx_vec, size(x))
df = NoTangent()
dargs = ntuple(unimplemented_tangent, Val(N))
dargs = ntuple(unimplemented_tangent, N)
return (df, project_x(dx), dargs...)
end

Expand Down
8 changes: 0 additions & 8 deletions test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,6 @@ function test_implicit_rrule(scen::Scenario)
@test z == z_true
@test dimpl isa NoTangent
@test dx ≈ dx_true
ChainRulesTestUtils.test_rrule(
implicit,
scen.x,
scen.args...;
rtol=1e-3,
check_inferred=false,
output_tangent=(copy(y), copy(z)),
)
end
end

Expand Down
Loading