Add DirectLinearSolver support for length-1 vectors#200
Add DirectLinearSolver support for length-1 vectors#200gdalle merged 3 commits intoJuliaDecisionFocusedLearning:mainfrom
DirectLinearSolver support for length-1 vectors#200Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
Oh, I missed the fact that |
|
While I like the new example, I wonder whether it brings anything that is not already in the simpler Optim demo, documentation wise? If not, since our main goal is to test the length-1 case, perhaps a simpler test in the |
|
The new example doesn't bring anything new except maybe the computation of a Hessian (only with I've just pushed modifications that remove the "new example" (as well as the |
gdalle
left a comment
There was a problem hiding this comment.
perfect, thanks! let's leave investigations of second-order stuff for a future PR!
This PR enables the use of the
DirectLinearSolverwhen theforwardfunction returns vector of length 1. This fixes #199.Note : I've placed some tests in the
examples/4_gallery.jlfile. I didn't know exactly where to place them so I thought that maybe, in a futur work, there could be a documentation page where misc. examples are listed, some kind of "gallery". But I can move them elsewhere if you prefer.