Allow container to be placed on a different object#16745
Open
jbellsey wants to merge 1 commit intoLeaVerou:gh-pagesfrom
Open
Allow container to be placed on a different object#16745jbellsey wants to merge 1 commit intoLeaVerou:gh-pagesfrom
jbellsey wants to merge 1 commit intoLeaVerou:gh-pagesfrom
Conversation
This commit allows the user to force the awesomplete container (and its elements) to be placed around an element other than the provided input. Why? As it stands, Awesomplete is incompatible with the Insignia tag-editing library (https://github.com/bevacqua/insignia). That library requires that the input field has no siblings, and Awesomplete creates siblings. I have no doubt that this small change will be useful for other installations as well.
Owner
|
Thanks for working on this. I think this issue can be fixed by #16743, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows the user to force the awesomplete container (and its elements) to be placed around an element other than the provided input.
Why? As it stands, Awesomplete is incompatible with the Insignia tag-editing library (https://github.com/bevacqua/insignia). That library requires that the input field has no siblings, and Awesomplete creates siblings.
I have no doubt that this small change will be useful for other installations as well.