Skip to content

fix(electron): resolve CodeQL alerts #22 and #25 in electron.js#4136

Merged
khassel merged 2 commits intoMagicMirrorOrg:developfrom
KristjanESPERANTO:fix/electron-switch
May 3, 2026
Merged

fix(electron): resolve CodeQL alerts #22 and #25 in electron.js#4136
khassel merged 2 commits intoMagicMirrorOrg:developfrom
KristjanESPERANTO:fix/electron-switch

Conversation

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

I reviewed the CodeQL alerts for js/electron.js:

Both point to real bugs.

  • #25: The window size fallback was written as a comma expression ((800, 600)), so it did not produce the expected object structure { width, height }. I am not surprised it went unnoticed because it sits in a fallback path.
  • #22: ...new Set(electronSwitchesDefaults, config.electronSwitches) silently ignored the second parameter. As a result, custom electronSwitches were never applied. I am wondering: this has been broken since PR Add custom switches for electron mainWindow #2643 introduced it, so I'm quite sure it could not have worked as intended in that form. Why didn't anyone (not even @eouia) notice that? 🤔

Changes

  • Fix for #25:
    • Corrects the fallback from (800, 600) to a valid size object { width: 800, height: 600 }.
  • Fix for #22:
    • Sets the default switch explicitly as a correct key-value pair:
      • app.commandLine.appendSwitch("autoplay-policy", "no-user-gesture-required")
    • Applies custom config.electronSwitches individually afterward.

@khassel khassel merged commit d20306c into MagicMirrorOrg:develop May 3, 2026
12 checks passed
@KristjanESPERANTO KristjanESPERANTO deleted the fix/electron-switch branch May 3, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants