refactor(utils): drop ajv dependency#4142
Open
KristjanESPERANTO wants to merge 2 commits intoMagicMirrorOrg:developfrom
Open
refactor(utils): drop ajv dependency#4142KristjanESPERANTO wants to merge 2 commits intoMagicMirrorOrg:developfrom
KristjanESPERANTO wants to merge 2 commits intoMagicMirrorOrg:developfrom
Conversation
The previous schema only enforced basic structure checks, so ajv added unnecessary complexity for this single validation path. Replace ajv compile/validate with explicit JavaScript checks while keeping existing behavior for required module entries, position type validation, and unknown-position warnings. Also removes a fragile ajv error-formatting path and fixes the JSDoc parameter type: data is the full config object, not a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
ajvfrom module position validation injs/utils.jsand replaces it with straightforward JavaScript checks. The old schema only covered a few basic structure rules, so usingajvhere felt heavier than necessary. The updated validation keeps the same expected behavior for valid configs and unknown-position warnings, but the code path is now easier to read and easier to reason about when something goes wrong.Outcome: same validation behavior, one less dependency, less lines of production code and better test coverage.