Update build scripts for Windows builds#1843
Draft
fnuecke wants to merge 6 commits intoOpenDroneMap:masterfrom
Draft
Update build scripts for Windows builds#1843fnuecke wants to merge 6 commits intoOpenDroneMap:masterfrom
fnuecke wants to merge 6 commits intoOpenDroneMap:masterfrom
Conversation
…ency when using VS 2022.
…l match Python used for build, which may fail if version is not the one of the embedded Python.
Contributor
|
Thanks @fnuecke ! I will wait on merging this since our build process uses an older version of VS (but we'll need to upgrade at some point and this PR will probably help us do so when it's time). 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run into some issues while building for Windows on the current master / v3.5.5. Most of this boils down to me using VS 2022 and having had a version of Python installed that did not match the one bundled with the installer. But I've also run into one issue I'm genuinely not sure about.
python-dateutilas requirement for the virtual environment, otherwise this would result in an import error at runtime for me.cv2. Without this, OpenCV initialization fails for me while trying to load its native lib. I traced this down to it breaking if running after PIL'sImage.pyimported its_imagingnative lib. The error I get without this change isImportError: DLL load failed while importing cv2: A dynamic link library (DLL) initialization routine failed.. No idea why this is; if anyone has an idea how to properly fix this, that would be much appreciated.