feat: support implicit OAuth in VS Code remote environments#285
Merged
feat: support implicit OAuth in VS Code remote environments#285
Conversation
Remove the "Developer Preview" note and disclaimer from the CLI README, the preview banner from the docs site theme, and all associated CSS.
Add openBrowser and redirectUri options to ImplicitOAuthConfig, AuthCredentials, and CreateOAuthOptions so callers can customize the browser opener and redirect URI for implicit auth flows. The VS Code extension now uses vscode.env.openExternal (opens browser on the client) and vscode.env.asExternalUri (resolves localhost to the Codespaces forwarded port URL) so implicit OAuth works in remote environments where the `open` package cannot reach the user's browser.
clavery
requested review from
patricksullivansf,
wei-liu-sf and
yhsieh1
as code owners
The content tree, webdav tree, and log tailing features use configProvider.getInstance() which creates a B2CInstance with its own internal auth resolution. Thread redirectUri and openBrowser through OAuthAuthConfig, AuthConfig, createInstanceFromConfig, and createB2CInstance so these features also use vscode.env.openExternal in remote environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openBrowserandredirectUrioptions toImplicitOAuthConfig,AuthCredentials, andCreateOAuthOptionsin the SDK so callers can customize the implicit auth flowvscode.env.openExternal(opens browser on the client machine) andvscode.env.asExternalUri(resolveslocalhost:8080to the Codespaces forwarded port URL likehttps://<name>-8080.app.github.dev)SFCC_REDIRECT_URIconfigurationTest plan
*.app.github.devSFCC_REDIRECT_URIenv var still takes precedence when explicitly set