feat: add --wait to mrt bundle deploy and align SDK wait functions#305
Merged
feat: add --wait to mrt bundle deploy and align SDK wait functions#305
Conversation
Align all SDK wait functions (waitForJob, waitForEnv) to the canonical pattern established by waitForSandbox/waitForClone: structured PollInfo callbacks, seconds-based options, injectable sleep for testing, and initial delay before first poll. Add --wait/--poll-interval/--timeout flags to mrt bundle deploy, and add missing --poll-interval/--timeout flags to mrt env create and job run for consistency across all CLI wait commands.
Update FAST_WAIT_OPTIONS in content/export and site-archive tests to use pollIntervalSeconds and injectable sleep instead of the removed pollInterval property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--waitflag tomrt bundle deploy— polls until deployment completes, with--poll-interval(default 10s) and--timeout(default 600s) flagswaitForJob,waitForEnv) to the canonical pattern established bywaitForSandbox/waitForClone: structuredPollInfocallbacks (onPollwithelapsedSeconds/status), seconds-based options (pollIntervalSeconds,timeoutSeconds), injectablesleepfor testing, and initial delay before first poll--poll-interval/--timeoutonmrt env create,--poll-intervalonjob runwaitForJobandwaitForEnvto use the new interfaces (job run/wait/import/export, content list/export, sites cartridges add/remove/set, mrt env create)mrt bundle deploy,mrt env create, andjob runTest plan
b2c mrt bundle deploy -p <project> -e <env> --waitb2c mrt bundle deploy -p <project> -e <env> --wait --timeout 30(timeout)b2c mrt env create <slug> -p <project> --name "Test" --wait --poll-interval 5