feat(mrt-utilities): Add MRT-prefixed env configuration for dev data-store#385
Merged
feat(mrt-utilities): Add MRT-prefixed env configuration for dev data-store#385
Conversation
bendvc
changed the title
bendvc
changed the title
kevinxh
reviewed
Apr 27, 2026
|
|
||
| function readDefaultsFromEnv(): Record<string, Record<string, unknown>> { | ||
| const raw = process.env.SFNEXT_DATA_STORE_DEFAULTS; | ||
| const raw = process.env.MRT_DATA_STORE_DEFAULTS ?? process.env.SFNEXT_DATA_STORE_DEFAULTS; |
There was a problem hiding this comment.
wanna leave a comment here to explain why there is SFNEXT_DATA_STORE_DEFAULTS in the code base?
kevinxh
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
MRT_DATA_STORE_DEFAULTSandMRT_DATA_STORE_WARN_ON_MISSINGto make the feature generic beyond SFNEXT-specific consumersSFNEXT_DATA_STORE_DEFAULTSandSFNEXT_DATA_STORE_WARN_ON_MISSINGwhen the newMRT_*variables are not setMRT_*names, while intentionally not documenting the legacySFNEXT_*variablesTest Plan
pnpm --filter @salesforce/mrt-utilities run lint:agentpnpm --filter @salesforce/mrt-utilities run test:agentpnpm --filter @salesforce/mrt-utilities run typecheck:agentnode --conditions dev-data-storeconfirms env-backed values resolve and missing keys throwDataStoreNotFoundError