fix: make OAuth credentials conditional in code commands#74
Merged
Conversation
OAuth is now only required for code deploy/watch when actually needed: - No code version specified (auto-discovery via OCAPI) - --reload flag is set (reload via OCAPI) When using basic auth with an explicit --code-version, OAuth is not required. Error messages now explain why OAuth is needed and link to configuration docs. Closes #35
yhsieh1
reviewed
Jan 26, 2026
yhsieh1
previously approved these changes
Jan 26, 2026
Test both error paths when OAuth credentials are missing: - No code version specified (needs auto-discovery) - --reload flag set (needs OCAPI call)
yhsieh1
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code deployandcode watchwhen actually needed--code-versionis providedChanges
code deploy: OAuth only required when no code version specified (auto-discovery) or--reloadflag is setcode watch: OAuth only required when no code version specified (auto-discovery)Closes #35