Draft
Conversation
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
Contributor
Author
|
This will remain in draft until properties are officially fully released and ready to go. |
sovdeeth
requested changes
Oct 26, 2025
Absolutionism
added
2.14
sovdeeth
requested changes
Nov 6, 2025
| Skript.registerEffect(EffWorldLoad.class, | ||
| "load [the] world[s] %strings% [with environment %-environment%]", | ||
| "unload [[the] world[s]] %worlds% [:without saving]" | ||
| "unload [[the] world[s]] %worlds% without saving" |
Member
There was a problem hiding this comment.
note that technically this removes the patterns unload [the] world[s] %worlds% which is breaking.
Contributor
Author
There was a problem hiding this comment.
What would you advise to be done?
Member
There was a problem hiding this comment.
either
a) add it back
b) note it as a breaking change
i'm not partial to either but a is probably better experience for users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current property system does not yet have support for common effect syntaxes and no common property handler used for effects.
Solution
Adds PropertyBaseEffect, class for using common effects with only 1 input in the syntax.
Adds EffectHandler, common handler used in PropertyBaseEffect
Adds effects and properties for: load, unload, reload, enable, and disable.
ScriptClassInfo includes all of these properties
Moves classinfo for World into it's own class, WorldClassInfo, with an unload property.
Refactors EffScriptFile to enable/load/reload a script with errors to be printed, removes some patterns that are now in ExprScript, and moved into org.
Refactors EffWorldLoad with the only unload option to be without saving
Testing Completed
quickTest
Supporting Information
N/A
Note
PR currently fails due to pattern conflicts because of property syntaxes and their original classes.
Completes: none
Related: none