Lower implicit priority for syntaxes involving regular expressions

[bluelhf]

Problem

As documented by @TheLimeGlass in issue #8534, Skript prefers EffDoIf(ExprDefaultValue) over ExprTernary in situations where do-if should have lower priority. This is because EffDoIf does not declare its priority as PATTERN_MATCHES_EVERYTHING despite involving the regular expression <.+> in its pattern. The current implementation for calculating the implicit priority of a syntax does not take regular expressions into account, even though it could; PATTERN_MATCHES_EVERYTHING is intended precisely for syntaxes that have these kinds of regular expressions.

Solution

A general solution is given. This PR adjusts the implicit priority calculation to automatically apply a priority of PATTERN_MATCHES_EVERYTHING to syntaxes that use regular expressions (have an angle bracket in one or more of their patterns). An additional conditional case is added to estimatePriority in SyntaxInfoImpl.

Testing Completed

I verified that this change solves the issue documented in #8534, and does not break our tests (using quickTest). I've also used skUnity Docs to identify all syntaxes that have a pattern that includes a regular expression, and did not immediately see any patterns that could reasonably break because of these changes. A tab-separated list of all syntaxes documented on skUnity containing < in their pattern (as retrieved from the skUnity Docs API) is given.¹

Supporting Information

All skUnity syntaxes can be retrieved using an API key from the URL https://api.skunity.com/v1/API_KEY_HERE/docs/getAllSyntax. I used my own personal API key, which I found on the skUnity Dashboard.

---

Completes: #8534
Related: Discussion on the SkriptLang Discord
AI assistance: For creating the JQ pattern that exported syntax patterns containing < from the skUnity getAllSyntax JSON

Footnotes

1. regexful.csv on GitHub Gist ↩

[APickledWalrus]

I think this is fine as a default assumption. Nice solution