fixup! Update VMware Tools links after Broadcom acquisition#338
Open
Jamie- wants to merge 1 commit intoStefanScherer:mainfrom
Open
fixup! Update VMware Tools links after Broadcom acquisition#338Jamie- wants to merge 1 commit intoStefanScherer:mainfrom
Jamie- wants to merge 1 commit intoStefanScherer:mainfrom
Conversation
Fixes code added in 46f9305 to support relative links. This is currently silently failing as is caught by the Try/Catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code added in 46f9305 to support relative links.
The directory index at https://packages.vmware.com/tools/releases/latest/windows/ uses relative URLs for file links, so the resulting
$newestVMwareToolsURLends up just being a filename.As this is in a Try block, it gets caught, we use the fallback URL and quietly continue.