Skip to content

Region Biomes Fix #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItzKatze merged 1 commit into from
Dec 29, 2025
Merged

Region Biomes Fix #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions ....skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/SkyBlockGenericLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
import java.lang.reflect.InvocationTargetException;
import java.time.Duration;
import java.util.*;
import java.util.concurrent.CompletableFuture;
import java.util.stream.Stream;

public record SkyBlockGenericLoader(HypixelTypeLoader typeLoader) {
Expand Down Expand Up @@ -303,7 +304,6 @@ public void initialize(MinecraftServer server) {
.build());
SkyBlockIsland.runVacantLoop(MinecraftServer.getSchedulerManager());

// Set region biomes
SkyBlockRegion.getRegions().forEach(region -> {
if (region.getServerType() != HypixelConst.getTypeLoader().getType()) return;
SkyBlockBiomeConfiguration biomeConfig = region.getType().getBiomeHandler();
Expand Down Expand Up @@ -579,14 +579,23 @@ public static <T> Stream<T> loopThroughPackage(String packageName, Class<T> claz
}

private void setBiome(int x, int y, int z, RegistryKey<Biome> biome) {
Chunk chunk = HypixelConst.getInstanceContainer().getChunk(CoordConversion.globalToChunk(x), CoordConversion.globalToChunk(z));
chunk.setBiome(x, y, z, biome);
CompletableFuture<Chunk> chunk = HypixelConst.getInstanceContainer().loadChunk(CoordConversion.globalToChunk(x), CoordConversion.globalToChunk(z));
chunk.thenAccept((c) -> c.setBiome(x, y, z, biome));
}

private void setBiome(Pos start, Pos end, RegistryKey<Biome> biome) {
for (int x = start.blockX(); x <= end.blockX(); x++) {
for (int y = start.blockY(); y <= end.blockY(); y++) {
for (int z = start.blockZ(); z <= end.blockZ(); z++) {
int minX = Math.min(start.blockX(), end.blockX());
int maxX = Math.max(start.blockX(), end.blockX());

int minY = Math.min(start.blockY(), end.blockY());
int maxY = Math.max(start.blockY(), end.blockY());

int minZ = Math.min(start.blockZ(), end.blockZ());
int maxZ = Math.max(start.blockZ(), end.blockZ());

for (int x = minX; x <= maxX; x++) {
for (int y = minY; y <= maxY; y++) {
for (int z = minZ; z <= maxZ; z++) {
setBiome(x, y, z, biome);
}
}
Expand Down