Skip to content

typo and datapoint fix #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItzKatze merged 1 commit into from
Dec 30, 2025
Merged

typo and datapoint fix #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ava/net/swofty/type/skyblockgeneric/data/datapoints/DatapointCollectedMobTypeRewards.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import lombok.NoArgsConstructor;
import net.swofty.commons.protocol.Serializer;
import net.swofty.type.skyblockgeneric.data.SkyBlockDatapoint;
import org.json.JSONArray;
import org.json.JSONObject;

import java.util.ArrayList;
Expand All @@ -15,18 +16,17 @@ public DatapointCollectedMobTypeRewards(String key, PlayerCollectedMobTypeReward
super(key, value, new Serializer<>() {
@Override
public String serialize(PlayerCollectedMobTypeRewards value) {
JSONObject jsonObject = new JSONObject(value.collectedMobTypes);
return jsonObject.toString();
return new JSONArray(value.collectedMobTypes).toString();
}

@Override
public PlayerCollectedMobTypeRewards deserialize(String json) {
JSONObject jsonObject = new JSONObject(json);
JSONArray array = new JSONArray(json);
List<String> collectedMobTypes = new ArrayList<>();

jsonObject.getJSONArray("values").forEach((value) -> {
array.forEach(value -> {
if (value instanceof String)
collectedMobTypes.add(value.toString());
collectedMobTypes.add((String) value);
});

return new PlayerCollectedMobTypeRewards(collectedMobTypes);
Expand Down
2 changes: 1 addition & 1 deletion website/docs/setup/game-servers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ gameserver/
│ ├── collection/
│ ├── items/
│ ├── levels/
│ ├── pack_texturess/ # Optional
│ ├── pack_textures/ # Optional
│ ├── reforges/
│ ├── items/
│ ├── skills/
Expand Down