Small fixes#712
Closed
vicente-pixel wants to merge 4 commits intoSwofty-Developments:masterfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
ArikSquad
reviewed
Feb 7, 2026
|
|
||
| private String formatCoinAmount(double amount) { | ||
| if (amount >= 1000) { | ||
| return StringUtility.shortenNumber(amount).replace("K", "k"); |
Contributor
There was a problem hiding this comment.
Please make a StringUtility#formatCurrency
ArikSquad
reviewed
Feb 7, 2026
Comment on lines
+61
to
+70
| layout.slot(49, (s, c) -> ItemStack.builder(Material.ARROW) | ||
| .set(DataComponents.CUSTOM_NAME, Component.text("§aGo Back")) | ||
| .set(DataComponents.LORE, List.of(Component.text("§7To SkyBlock Menu") | ||
| .decoration(TextDecoration.ITALIC, false))), | ||
| (click, c) -> { | ||
| ViewNavigator navigator = ViewNavigator.get(c.player()); | ||
| if (!navigator.pop()) { | ||
| c.player().closeInventory(); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
Use the proper component that we have for this...
ArikSquad
reviewed
Feb 7, 2026
| Key.key("skyblock:island"), | ||
| DimensionType.builder() | ||
| .ambientLight(1) | ||
| .ambientLight(0f) |
Contributor
There was a problem hiding this comment.
just remove the field if you're going to do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Adds/Fixes the following: