Skip to content

Add ACR name parameter to parameter files#1

Merged
Vamshi-Microsoft merged 1 commit intomainfrom
vk-deploy-final
Oct 15, 2025
Merged

Add ACR name parameter to parameter files#1
Vamshi-Microsoft merged 1 commit intomainfrom
vk-deploy-final

Conversation

@Vamshi-Microsoft
Copy link
Copy Markdown
Owner

Purpose

This pull request adds support for specifying the Azure Container Registry (ACR) name as a parameter in both the main and WAF infrastructure parameter files. This allows for more flexible configuration of the ACR used in deployments.

Infrastructure configuration:

  • Added the acrName parameter to infra/main.parameters.json to allow the ACR name to be set via environment variables.
  • Added the acrName parameter to infra/main.waf.parameters.json for consistent support in WAF-related deployments.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Vamshi-Microsoft Vamshi-Microsoft merged commit 4ca782e into main Oct 15, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant