Skip to content

feat: merge dockerparam into main #2

Merged
Vamshi-Microsoft merged 3 commits intomainfrom
vk-deploy-dockerparam
Oct 17, 2025
Merged

feat: merge dockerparam into main #2
Vamshi-Microsoft merged 3 commits intomainfrom
vk-deploy-dockerparam

Conversation

@Vamshi-Microsoft
Copy link
Copy Markdown
Owner

Purpose

This pull request updates and refactors the deployment workflow in .github/workflows/deploy-Parameterized.yml (renamed from deploy-unified.yml) to improve flexibility, parameterization, and clarity for both automatic and manual triggers. The changes allow for more granular control over Docker image building, resource cleanup, and environment configuration, with clear separation between manual and automated runs. Additionally, a minor update was made to the Azure Search service configuration in infra/main.bicep.

Workflow parameterization and trigger enhancements:

  • Added new workflow triggers for pull_request and improved workflow_run conditions, enabling deployment on more branch events and scheduled runs. [1] [2]
  • Introduced the build_docker_image parameter and logic to distinguish between building a new Docker image or using an existing one, with corresponding environment variable handling for both automatic and manual workflow dispatches. [1] [2] [3]

Deployment job improvements:

  • Added a configuration summary step for better visibility into workflow settings and trigger type, and updated environment variable logic to enforce non-WAF/non-EXP for automatic triggers.
  • Refined Docker image tag generation and selection: unique tags are generated for manual runs, while branch-based tags are used for automatic runs; Docker build and push steps are now conditional on the new parameter. [1] [2] [3]
  • Improved environment setup by conditionally configuring Azure Container Registry only when building a new Docker image.

Resource cleanup and testing logic:

  • Updated e2e test and cleanup job conditions to run for automatic triggers or when manually enabled, ensuring resource cleanup only for custom image tags and not for default images. [1] [2] [3]

Infrastructure configuration:

  • Changed the Azure Search service SKU logic in infra/main.bicep to always use standard when scalability is enabled, removing the fallback to basic.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Vamshi-Microsoft Vamshi-Microsoft merged commit 7b5d8ee into main Oct 17, 2025
9 of 11 checks passed
Vamshi-Microsoft pushed a commit that referenced this pull request Feb 11, 2026
Infra code updates, docker file addition for frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant