Merged
Conversation
…ptions and improved image tag handling
…or deployment status
Vamshi-Microsoft
pushed a commit
that referenced
this pull request
Feb 11, 2026
chore: removed the az login dependency during deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors and enhances the workflow in
.github/workflows/deploy-Parameterized.ymlto improve clarity, modularity, and control over Docker image building, deployment, notification, and resource cleanup. The changes introduce a dedicated Docker build job, unify image tag handling, add deployment notifications, clarify job conditions, and update resource extraction logic for better maintainability and reliability.Workflow modularization and control:
Added a dedicated
docker-buildjob that runs only on manual workflow dispatch when the "Build and push Docker image" option is checked. This job generates a unique Docker image tag, builds, and pushes the image to Azure Container Registry.Refactored image tag determination in the
deployjob to use the output from thedocker-buildjob when available, ensuring consistent image tag usage across jobs. The deploy job now depends on the docker-build job and uses a newdetermine_image_tagstep. [1] [2]Notification and output improvements:
Added a post-deployment notification step that sends an email via a Logic App webhook, including deployment details and run URL, with separate messages for success and failure.
Updated all references to the Docker image tag in deployment and environment setup steps to use the output from the new
determine_image_tagstep for consistency. (F7a693a3L391R391, F7a693a3L403R403, F7a693a3L422R422)Resource extraction and cleanup:
Updated resource extraction after deployment to use new output variable names (e.g.,
AZURE_COSMOSDB_ACCOUNTinstead ofCOSMOS_DB_ACCOUNT_NAME) and removed unused variables related to SQL and managed identities for a cleaner output. [1] [2]Improved the cleanup job to more reliably determine which Docker image tags to delete, preferring the output from the docker-build job when available, and skipping cleanup for standard branch images. The cleanup job now depends on all relevant jobs. [1] [2]
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information