Skip to content

feat: Vk dockerbuild job#4

Merged
Vamshi-Microsoft merged 2 commits intomainfrom
vk-dockerbuild-job
Oct 30, 2025
Merged

feat: Vk dockerbuild job#4
Vamshi-Microsoft merged 2 commits intomainfrom
vk-dockerbuild-job

Conversation

@Vamshi-Microsoft
Copy link
Copy Markdown
Owner

Purpose

This pull request refactors and enhances the workflow in .github/workflows/deploy-Parameterized.yml to improve clarity, modularity, and control over Docker image building, deployment, notification, and resource cleanup. The changes introduce a dedicated Docker build job, unify image tag handling, add deployment notifications, clarify job conditions, and update resource extraction logic for better maintainability and reliability.

Workflow modularization and control:

  • Added a dedicated docker-build job that runs only on manual workflow dispatch when the "Build and push Docker image" option is checked. This job generates a unique Docker image tag, builds, and pushes the image to Azure Container Registry.

  • Refactored image tag determination in the deploy job to use the output from the docker-build job when available, ensuring consistent image tag usage across jobs. The deploy job now depends on the docker-build job and uses a new determine_image_tag step. [1] [2]

Notification and output improvements:

  • Added a post-deployment notification step that sends an email via a Logic App webhook, including deployment details and run URL, with separate messages for success and failure.

  • Updated all references to the Docker image tag in deployment and environment setup steps to use the output from the new determine_image_tag step for consistency. (F7a693a3L391R391, F7a693a3L403R403, F7a693a3L422R422)

Resource extraction and cleanup:

  • Updated resource extraction after deployment to use new output variable names (e.g., AZURE_COSMOSDB_ACCOUNT instead of COSMOS_DB_ACCOUNT_NAME) and removed unused variables related to SQL and managed identities for a cleaner output. [1] [2]

  • Improved the cleanup job to more reliably determine which Docker image tags to delete, preferring the output from the docker-build job when available, and skipping cleanup for standard branch images. The cleanup job now depends on all relevant jobs. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Vamshi-Microsoft Vamshi-Microsoft merged commit af6badf into main Oct 30, 2025
8 checks passed
Vamshi-Microsoft pushed a commit that referenced this pull request Feb 11, 2026
chore: removed the az login dependency during deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant