Skip to content

Fixed buffer pool#444

Draft
proteetpaul wants to merge 20 commits intoXiangpengHao:mainfrom
proteetpaul:fixed-buffer-pool
Draft

Fixed buffer pool#444
proteetpaul wants to merge 20 commits intoXiangpengHao:mainfrom
proteetpaul:fixed-buffer-pool

Conversation

@proteetpaul
Copy link
Copy Markdown
Contributor

@proteetpaul proteetpaul commented Nov 24, 2025

Add a pool for fixed buffers in io uring. This reduces CPU overhead during IO submission as the buffers don't need to be pinned to memory.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 0% with 496 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.86%. Comparing base (cbc679d) to head (a8f4e74).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/common/src/memory/tcache.rs 0.00% 220 Missing ⚠️
src/common/src/memory/pool.rs 0.00% 95 Missing ⚠️
src/common/src/memory/arena.rs 0.00% 87 Missing ⚠️
src/common/src/memory/page.rs 0.00% 55 Missing ⚠️
src/common/src/memory/segment.rs 0.00% 39 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cbc679d) and HEAD (a8f4e74). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cbc679d) HEAD (a8f4e74)
4 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #444       +/-   ##
===========================================
- Coverage   83.59%   37.86%   -45.74%     
===========================================
  Files          78       82        +4     
  Lines       20123    14029     -6094     
  Branches    20123    14029     -6094     
===========================================
- Hits        16822     5312    -11510     
- Misses       2893     8507     +5614     
+ Partials      408      210      -198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

proteetpaul and others added 10 commits November 30, 2025 15:29
This commit fixes the following bugs:
- Sets file offset correctly in read task for fixed buffers
- Sets correct block size in tcache
- Clears free list of page before setting block size
This commit implements a lockfree queue to hold frees by different
threads. Freed blocks are cleaned up later, either through periodic
cleanup operations or when under memory pressure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant