Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 83.83% 83.89% +0.05%
==========================================
Files 97 98 +1
Lines 21526 21721 +195
Branches 21526 21721 +195
==========================================
+ Hits 18047 18222 +175
- Misses 3054 3066 +12
- Partials 425 433 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit implements a buffer pool for fixed buffers in order to remove memory allocation and pinning overheads during io submission. The buffer pool is integrated into the uring threadpool mechanism. Also implements minor optimizations in the uring threadpool, such as syscall batching.
- Syscall batching - Handle multiple sqes per IO task - Spawn a batch of tasks on the runtime
Partition batches more evenly, add support for other io modes, minor code cleanup
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| Security | 49 high |
| Complexity | 6 medium |
🟢 Metrics 165 complexity · 103 duplication
Metric Results Complexity 165 Duplication 103
TIP This summary will be updated as you push new changes. Give us feedback
- Steal tasks only from the global queue - Basic admission control: Only a fixed number of tasks are admitted per worker
8142075 to
2c62fbd
Compare
8bb64ac to
709be25
Compare
- Table formatting for results - Use a tokio runtime if io mode is std-blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a multi-threaded runtime that integrates io_uring. Each worker thread has the following components:
Tasks are submitted to the worker thread using a crossbeam channel, and results are propagated back to the caller using a oneshot channel. When a task requires IO, it will yield to the runtime. The runtime is responsible for submitting IO's to the ring and polling IO completions. Upon completion, the runtime will unpark the corresponding task.
TODO():