Non-role input types require an accessible name#2228
Merged
Conversation
Collaborator
|
Closes #2123. |
Jym77
previously requested changes
Dec 19, 2024
Collaborator
|
Already approving. Good catch @Jym77 |
giacomo-petri
approved these changes
Dec 19, 2024
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
carlosapaduarte
approved these changes
Feb 6, 2025
Jym77
approved these changes
Feb 6, 2025
Collaborator
Jym77
left a comment
There was a problem hiding this comment.
Minor improvement on the background note.
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ct-rules.github.io into form-control-all-input-types
Collaborator
|
Call for Review ends on January 15th. |
Collaborator
|
Call for Reviews has ended. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when reviewing the form control rule. I think we need to do the same for the
Form field label is descriptiverule. Leaving this as a draft PR until then.Need for Call for Review: 1 week
How to Review And Approve