[Editorial] - [5c01ea] ARIA state or property is permitted - Inapplicable Example 1 improvement (acc name)#2257
Merged
WilcoFiers merged 4 commits intodevelopfrom Apr 10, 2025
Conversation
giacomo-petri
added
the
Editorial
giacomo-petri
requested review from
Jym77,
WilcoFiers,
carlosapaduarte,
dan-tripp-siteimprove,
dd8 and
tombrunet
Jym77
requested changes
Feb 3, 2025
carlosapaduarte
approved these changes
Feb 6, 2025
Jym77
approved these changes
Feb 6, 2025
dan-tripp-siteimprove
approved these changes
Feb 10, 2025
Member
|
This should not be an editorial update. It changes an example, we'll always want a CfR for that. |
WilcoFiers
approved these changes
Feb 13, 2025
Collaborator
|
Call for review end on February 28th. |
Jym77
added
Review Call 1 week
colabottles
approved these changes
Feb 20, 2025
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue(s): #2256
Description:
This PR adds the required acc name to the element with explicit role="region"
from
<div role="region">A region of content</div>to
<div role="region" aria-label="Region name">A region of content</div>Need for Call for Review:
This can be merged with 1 approval