Skip to content

Updated required owned elms rule description#2305

Merged
WilcoFiers merged 4 commits intodevelopfrom
WilcoFiers-patch-6
Apr 10, 2025
Merged

Updated required owned elms rule description#2305
WilcoFiers merged 4 commits intodevelopfrom
WilcoFiers-patch-6

Conversation

@WilcoFiers
Copy link
Copy Markdown
Member

When reviewing this rule I noticed the description is out of sync with what it actually requires.

Need for Call for Review: none


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Comment thread _rules/aria-required-owned-element-bc4a75.md Outdated
Copy link
Copy Markdown
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not approving since Dan already did.

Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 20, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 1406468
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67f7c1b56c0c6700085e1d9f
😎 Deploy Preview https://deploy-preview-2305--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WilcoFiers WilcoFiers merged commit 6c575ee into develop Apr 10, 2025
6 checks passed
@WilcoFiers WilcoFiers deleted the WilcoFiers-patch-6 branch April 10, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants