[a25f45] Headers attribute specified on a cell refers to cells in the same table element - Updated Inapplicable Example 6#2312
Merged
carlosapaduarte merged 3 commits intodevelopfrom Apr 22, 2025
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
giacomo-petri
requested review from
Jym77,
WilcoFiers,
dan-tripp-siteimprove,
dd8,
kengdoj and
tombrunet
HelenBurge
previously approved these changes
Mar 13, 2025
Collaborator
HelenBurge
left a comment
HelenBurge
left a comment
There was a problem hiding this comment.
Please add https://www.w3.org/TR/wai-aria-1.2/#region in the PR details
daniel-montalvo
previously approved these changes
Mar 13, 2025
Collaborator
daniel-montalvo
left a comment
daniel-montalvo
left a comment
There was a problem hiding this comment.
Sounds reasonable
dan-tripp-siteimprove
previously approved these changes
Mar 27, 2025
WilcoFiers
reviewed
Mar 31, 2025
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
giacomo-petri
requested review from
HelenBurge,
WilcoFiers,
dan-tripp-siteimprove and
daniel-montalvo
giacomo-petri
dismissed stale reviews from dan-tripp-siteimprove, daniel-montalvo, and HelenBurge
example updated with role heading
daniel-montalvo
approved these changes
Apr 9, 2025
carlosapaduarte
approved these changes
Apr 9, 2025
WilcoFiers
approved these changes
Apr 10, 2025
Collaborator
Author
|
Call for review ends on April 18th. |
giacomo-petri
added
Review Call 1 week
Collaborator
Author
|
This is ready to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue: #2268
Role region without acc name is ignored.
Added an aria-label attribute to the
tableelement with roleregionso that the table is exposed as a region rather than a table (that is currently invalidating the example, by making it applicable).Need for Call for Review:
This will require a 1 week Call for Review
How to Review And Approve