Skip to content

[4e8ab6] Element with role attribute has required states and properties - Removed Combobox Failed Example 6#2313

Merged
carlosapaduarte merged 1 commit intodevelopfrom
giacomo-petri-4e8ab6-removed-failed-6
Apr 22, 2025
Merged

[4e8ab6] Element with role attribute has required states and properties - Removed Combobox Failed Example 6#2313
carlosapaduarte merged 1 commit intodevelopfrom
giacomo-petri-4e8ab6-removed-failed-6

Conversation

@giacomo-petri
Copy link
Copy Markdown
Collaborator

Closes issue: #2310

ARIA has removed the aria-controls requirement from combobox, so failed example 6 has been removed.

Need for Call for Review:
This will require a 1 week Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 6, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit b4eed9a
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67c9cff9e624c50008ecfcc2
😎 Deploy Preview https://deploy-preview-2313--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Collaborator

@dan-tripp-siteimprove dan-tripp-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be beneficial for this PR to add a mention (say, in the rule's Background or Bibliography) that this rule now "partially targets" ARIA 1.3 (assuming I'm understanding this situation correctly). We know that, and anyone could discover that by looking through this git history. But that's not ideal.

@giacomo-petri
Copy link
Copy Markdown
Collaborator Author

Thanks for the review @dan-tripp-siteimprove.

I'm not sure if we can reference a document that hasn't yet become a W3C Recommendation.
Perhaps we could add an Accessibility Support note stating that aria-controls is not supported and that ARIA plans to remove the requirement. Would that work for you?

@dan-tripp-siteimprove
Copy link
Copy Markdown
Collaborator

I'm not sure if we can reference a document that hasn't yet become a W3C Recommendation. Perhaps we could add an Accessibility Support note stating that aria-controls is not supported and that ARIA plans to remove the requirement. Would that work for you?

Yes. Would you like to do that, or should I?

Copy link
Copy Markdown
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giacomo-petri please send out the call for review.

@giacomo-petri
Copy link
Copy Markdown
Collaborator Author

Call for Reviews ends on April 18th

@giacomo-petri giacomo-petri added the Review call 2 weeks Call for review for new rules and big changes label Apr 5, 2025
@giacomo-petri
Copy link
Copy Markdown
Collaborator Author

This is ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review call 2 weeks Call for review for new rules and big changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants