Skip to content

Add test for validating aria properties for accessibility_requirements#2329

Merged
WilcoFiers merged 10 commits intoact-rules:developfrom
zlayaAvocado:validate-aria-properties
Jun 26, 2025
Merged

Add test for validating aria properties for accessibility_requirements#2329
WilcoFiers merged 10 commits intoact-rules:developfrom
zlayaAvocado:validate-aria-properties

Conversation

@zlayaAvocado
Copy link
Copy Markdown
Collaborator

@zlayaAvocado zlayaAvocado commented May 12, 2025

Adds a test for validating aria12 properties under accessibility_requirements. Since we expect a particular accessibility_requirements structure for the rules, the frontmatter tests act similar to typescript but for the frontmatter structure.

References this issue: #2328
The test job was failing before the fix: https://github.com/act-rules/act-rules.github.io/actions/runs/14984632459/job/42096095113

Need for Call for Review:
This will not require a Call for Review: adds a test


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 40ce631
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6838e8f69f29af0008fff77b
😎 Deploy Preview https://deploy-preview-2329--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread __tests__/frontmatter.js Outdated
@zlayaAvocado zlayaAvocado self-assigned this May 12, 2025
@zlayaAvocado zlayaAvocado changed the title Add test for validating aria properties Add test for validating aria properties for accessibility_requirements May 12, 2025
@zlayaAvocado zlayaAvocado marked this pull request as ready for review May 20, 2025 16:19
@zlayaAvocado zlayaAvocado requested a review from WilcoFiers May 20, 2025 16:19
Comment thread __tests__/frontmatter.js Outdated
@WilcoFiers WilcoFiers merged commit d549cb2 into act-rules:develop Jun 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants