Split ARIA props not prohibited from ARIA props permitted by WilcoFiers · Pull Request #2342 · act-rules/act-rules.github.io

WilcoFiers · 2025-07-31T14:48:50Z

Work in progress...

Closes issue(s):

closes #XXX (ADD ISSUE NUMBER HERE)

Need for Call for Review: 2 weeks

Pull Request Etiquette

When creating PR:

Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

netlify · 2025-07-31T14:48:55Z

✅ Deploy Preview for act-rules ready!

Name	Link
🔨 Latest commit	`363acfd`
🔍 Latest deploy log	https://app.netlify.com/projects/act-rules/deploys/68fa3804c0c92b000844870c
😎 Deploy Preview	https://deploy-preview-2342--act-rules.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

zlayaAvocado · 2025-10-02T14:49:55Z

+The `aria-brailleroledescription` property is [prohibited][] for an element with a `none` role.
+
+```html
+<h1 role="none" aria-brailleroledescription="Banana text">I like bananas</h1>
+```


do you think this could be replaced by role="presentation"? it would be clearer because I had to search that role="none" is just a synonym to that

Discussed on the call. "none" tends to be the preferred name for this these days.

carlosapaduarte

Some editorial changes

carlosapaduarte · 2025-10-02T14:48:48Z

 ## Background

-The presence of prohibited ARIA attributes is often the result of a developer using an incorrect role, or a misunderstanding of the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that a state or property which should exist is missing.
+The use of ARIA attributes that are not supported by a role is often the result of a developer either an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users.


Suggested change

The use of ARIA attributes that are not supported by a role is often the result of a developer either an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users.

The use of ARIA attributes that are not supported by a role is often the result of a developer either using an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users.

carlosapaduarte · 2025-10-02T14:58:02Z

+
+## Expectation
+
+No test target is [prohibited][] on the [semantic role][] of the element on which it is specified.


Suggested change

No test target is [prohibited][] on the [semantic role][] of the element on which it is specified.

The test target is not [prohibited][] on the [semantic role][] of the element on which it is specified.

dan-tripp-siteimprove · 2025-10-02T14:59:45Z

+    - JFK's "We Choose the Moon" speech excerpt is courtesy of NASA.
+---
+
+## Applicability


Maybe a nitpick: I would feel better if the word "attribute" was mentioned here (in the applicability). This would match other rules such as https://www.w3.org/WAI/standards-guidelines/act/rules/5f99a7/ , https://www.w3.org/WAI/standards-guidelines/act/rules/6a7281/ , https://www.w3.org/WAI/standards-guidelines/act/rules/674b10/ .

This comment also applies to the other rule.

Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>

Co-authored-by: Aleksandra <50310535+zlayaAvocado@users.noreply.github.com>

Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>

Accepted

Jym77 · 2025-10-16T11:44:10Z

@WilcoFiers This seems to solve/supercede both #2036 and #2037. Can you confirm and close them upon merging this?

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

Split ARIA props not prohibited from ARIA props permitted

0917f78

WilcoFiers added 4 commits July 31, 2025 17:21

update examples

3bae854

cleanup

431b7cf

update

81204fb

pass tests

1f4f2e0

WilcoFiers marked this pull request as ready for review August 21, 2025 16:47

carlosapaduarte self-requested a review August 21, 2025 16:49

carlosapaduarte added Rule Use this label for a new rule that does not exist already reviewers wanted labels Aug 21, 2025

shunguoy approved these changes Sep 4, 2025

View reviewed changes

WilcoFiers commented Oct 2, 2025

View reviewed changes

Comment thread _rules/aria-global-property-not-prohibited-kb1m8s.md Outdated

WilcoFiers commented Oct 2, 2025

View reviewed changes

Comment thread _rules/aria-global-property-not-prohibited-kb1m8s.md Outdated

zlayaAvocado previously requested changes Oct 2, 2025

View reviewed changes

Apply suggestion from @WilcoFiers

7ff605d

carlosapaduarte previously requested changes Oct 2, 2025

View reviewed changes

dan-tripp-siteimprove approved these changes Oct 2, 2025

View reviewed changes

WilcoFiers and others added 6 commits October 2, 2025 17:16

Apply suggestion from @WilcoFiers

3d789a7

Apply suggestion from @carlosapaduarte

d54eb76

Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>

Apply suggestion from @carlosapaduarte

cfba4df

Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>

Apply suggestion from @zlayaAvocado

4d27ae5

Co-authored-by: Aleksandra <50310535+zlayaAvocado@users.noreply.github.com>

Apply suggestion from @carlosapaduarte

1e8489b

Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>

Apply suggestion from @carlosapaduarte

e1a1402

Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>

WilcoFiers requested review from carlosapaduarte and zlayaAvocado October 2, 2025 15:20

colabottles approved these changes Oct 9, 2025

View reviewed changes

sage-putnam approved these changes Oct 9, 2025

View reviewed changes

WilcoFiers added the Review call 2 weeks Call for review for new rules and big changes label Oct 9, 2025

WilcoFiers removed the reviewers wanted label Oct 9, 2025

carlosapaduarte approved these changes Oct 9, 2025

View reviewed changes

Jym77 approved these changes Oct 16, 2025

View reviewed changes

Comment thread _rules/aria-global-property-not-prohibited-kb1m8s.md Outdated

Update _rules/aria-global-property-not-prohibited-kb1m8s.md

03761b1

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

WilcoFiers commented Oct 23, 2025

View reviewed changes

Comment thread _rules/aria-global-property-not-prohibited-kb1m8s.md Outdated

Apply suggestion from @WilcoFiers

363acfd

WilcoFiers merged commit 8a338c7 into develop Oct 23, 2025
6 checks passed

WilcoFiers deleted the aria-props-permitted-review branch October 23, 2025 14:17

Jym77 mentioned this pull request Apr 10, 2026

Add mapping from R18 to new ACT rule Siteimprove/alfa-act-r#284

Merged

	The use of ARIA attributes that are not supported by a role is often the result of a developer either an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users.
	The use of ARIA attributes that are not supported by a role is often the result of a developer either using an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users.


		## Expectation

		No test target is [prohibited][] on the [semantic role][] of the element on which it is specified.

	No test target is [prohibited][] on the [semantic role][] of the element on which it is specified.
	The test target is not [prohibited][] on the [semantic role][] of the element on which it is specified.

Conversation

WilcoFiers commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

Uh oh!

netlify bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for act-rules ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zlayaAvocado Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

WilcoFiers Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

carlosapaduarte left a comment

Choose a reason for hiding this comment

Uh oh!

carlosapaduarte Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlosapaduarte Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

dan-tripp-siteimprove Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

dan-tripp-siteimprove Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jym77 commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

WilcoFiers commented Jul 31, 2025 •

edited

Loading

netlify bot commented Jul 31, 2025 •

edited

Loading