Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
carlosapaduarte
approved these changes
Oct 27, 2025
WilcoFiers
approved these changes
Oct 27, 2025
giacomo-petri
approved these changes
Oct 27, 2025
Collaborator
Author
|
Call for Review ends on November 4th. |
colabottles
approved these changes
Oct 28, 2025
|
I think transcripts should be visible - how would a person with low vision know it's there or read it without forcing them to use a screen reader? |
Collaborator
Author
The requirement for visibility of transcript has been clarified in this WCAG discussion, where the conclusion is very clear. This is why we did #2187, this is just the stuff we missed there. |
Collaborator
Author
|
Call for Review has ended, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2187 we removed the need for transcripts to be visible, but somehow forgot to remove Failed Example 3 of an invisible transcript (which is now the same as Passed Example 3).
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review.
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve