Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
| import { config, cloneWcagActRules, commitAndPush } from './commons.mjs' | ||
| import { config, cloneWcagActRules } from './commons.mjs' | ||
|
|
||
| const ACT_TOOLS_PATH = process.env.ACT_TOOLS_PATH || './node_modules/act-tools'; |
There was a problem hiding this comment.
Note (non-blocking): I usually prefer nullish coalescence (??) in order to avoid the occasional blow-up with falsy-but-actually-correct values.
| const ACT_TOOLS_PATH = process.env.ACT_TOOLS_PATH || './node_modules/act-tools'; | |
| const ACT_TOOLS_PATH = process.env.ACT_TOOLS_PATH ?? './node_modules/act-tools'; |
| import { config, cloneWcagActRules, commitAndPush } from './commons.mjs' | ||
| import { config, cloneWcagActRules } from './commons.mjs' | ||
|
|
||
| const ACT_TOOLS_PATH = process.env.ACT_TOOLS_PATH || './node_modules/act-tools'; |
There was a problem hiding this comment.
Question: If act-tools is expected to be in node_modules, wouldn't an import { … } from "act-tools" work fine?
The cli code there seems to only call some other function with parameters read from CLI.
(a bit unrelated to this PR, since it was already how the other commands are run)
|
@remibetin We would benefit from your review of this functionality, also related to act-rules/act-tools#53, because all of this is transforming content that's intended to land on the WAI website. |
|
@daniel-montalvo Thanks for the mention, Daniel. We'll review this one too with @kfranqueiro. |
7 participants
Added a glossary top level page to the ACT rules W3C site.
Related PR: act-rules/act-tools#53
Closes issue(s):
Need for Call for Review:
How to Review And Approve
Preview the changes here