Skip to content

[b49b2e] Heading is descriptive -- Remove inapplicable examples of empty headings#2405

Open
daniel-montalvo wants to merge 1 commit intodevelopfrom
remove-inapplicable-empty-headings
Open

[b49b2e] Heading is descriptive -- Remove inapplicable examples of empty headings#2405
daniel-montalvo wants to merge 1 commit intodevelopfrom
remove-inapplicable-empty-headings

Conversation

@daniel-montalvo
Copy link
Copy Markdown
Collaborator

@daniel-montalvo daniel-montalvo commented Apr 15, 2026

Removes inapplicable examples of this rule where there's empty headings as there's no consensus on whether or not they should fail WCAG and, if they should fail, under wihch SC

Closes issue(s):

Need for Call for Review:
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this. >>


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@daniel-montalvo daniel-montalvo self-assigned this Apr 15, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 62d27f1
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/69dfa74c4a507d0008453f60
😎 Deploy Preview https://deploy-preview-2405--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a Background note to explain this? (lack of consensus, so not taking a stance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[b49b2e] Heading is descriptive - Inapplicable examples

3 participants