Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the GitHub Actions release workflow by removing redundant permissions configuration and eliminating the custom token setup. The changes align with GitHub Actions best practices for permissions management.
Key changes:
- Removes redundant top-level
permissions: contents: readblock - Eliminates custom
GITHUB_TOKENenvironment variable in favor of default token - Updates file pattern matching to include all Dockerfile variants
|
This PR is included in version 1.101.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply:Description of your changes
This PR updates the
.github/workflows/release.ymlworkflow to:permissions: contents: readblock.contents: write,issues: write,pull-requests: write) for the release job.GITHUB_TOKENenvironment variable, so the default GitHub Actions token is used for semantic-release.These changes simplify permissions management and follow GitHub Actions best practices.
How can we test changes
mainormasterand verify that semantic-release can create releases and push tags using the defaultGITHUB_TOKEN.