Skip to content

fix(TextArea): fix empty S2 TextArea height jumping when overlays are open#9933

Open
reidbarber wants to merge 2 commits intomainfrom
text-area-fix-height-jump
Open

fix(TextArea): fix empty S2 TextArea height jumping when overlays are open#9933
reidbarber wants to merge 2 commits intomainfrom
text-area-fix-height-jump

Conversation

@reidbarber
Copy link
Copy Markdown
Member

@reidbarber reidbarber commented Apr 15, 2026

Previously, when you had an empty S2 TextArea and opened an overlay, the height of the TextArea would jump +4.5px while the overlay was open.

Questions:

  • Could this potentially have alignment issues with labelPosition="side"? Chromatic looks good.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the new story and open the ContextualHelp. Verify that the TextArea's height does not change when the popover is opened.

🧢 Your Project:

@github-actions github-actions Bot added the S2 label Apr 15, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 15, 2026

@yihuiliao
Copy link
Copy Markdown
Member

now that we've changed align-items to start, the label and the placeholder are not aligned when labelPosition: side.

on the pr:

Screenshot 2026-04-20 at 11 04 27 AM

main:

Screenshot 2026-04-20 at 11 05 48 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants