fix: preserve multi-select ComboBox selections for custom input#9945
Open
romansndlr wants to merge 2 commits intoadobe:mainfrom
Open
fix: preserve multi-select ComboBox selections for custom input#9945romansndlr wants to merge 2 commits intoadobe:mainfrom
romansndlr wants to merge 2 commits intoadobe:mainfrom
Conversation
LFDanLu
reviewed
Apr 17, 2026
Member
LFDanLu
left a comment
There was a problem hiding this comment.
this seems to work well, will see about having the team test it fully in a upcoming test session. We may want to coordinate the "commitBehavior" prop addition with this PR since the Tab behavior does feel a bit odd with multiple selection IMO but that should probably be up to user discretion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowsCustomValuecommits or reverts custom inputEscape,Enter, andTabTesting
yarn jest packages/react-aria-components/test/ComboBox.test.js packages/react-stately/test/combobox/useComboBoxState.test.js --runInBandyarn eslint packages/react-stately/src/combobox/useComboBoxState.ts packages/react-aria-components/test/ComboBox.test.jsCloses #9837