fix(tailwindcss-react-aria-components): make not-* variants compose with native-overlapping states#9974
Open
mehdibha wants to merge 1 commit intoadobe:mainfrom
Open
fix(tailwindcss-react-aria-components): make not-* variants compose with native-overlapping states#9974mehdibha wants to merge 1 commit intoadobe:mainfrom
mehdibha wants to merge 1 commit intoadobe:mainfrom
Conversation
…ith native-overlapping states Tailwind's `not-*` compound walker bails when a variant produces more than one style rule per path. The dual-selector (array) shape used for variants that overlap native CSS states (hover, focus, disabled, invalid, etc.) emitted two sibling rules, so `not-disabled:`, `not-invalid:`, `not-focus:`, `not-hover:`, and similar utilities silently generated no CSS. Collapse both branches into a single `:is()` selector. `:where()` keeps specificity at (0,1,0) so cascade behavior matches the previous output. Hover additionally needs `@media (hover: hover)` to prevent sticky styles on touch devices. Emitting it as a CSS-in-JS object (instead of a string starting with `@media`) causes Tailwind to report the variant's compounds as `StyleRules | AtRules`, which preserves `group-hover:` / `peer-hover:` composition while still giving `not-hover:` the "1 style rule + 1 at-rule per path" shape the walker requires. Test coverage extended with `not-*`, `group-not-*`, `peer-not-*`, `has-not-*`, `not-group-*`, `peer-hover:`, and `in-*` variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
not-disabled:,not-invalid:,not-focus:,not-hover:and othernot-*utilities built on native-overlapping RAC variants silently emit no CSS.Tailwind's
not-*walker bails when a variant produces > 1 style rule per path (variants.ts#L470-L471), and the dual-selector (array) shape for these variants emits two siblings.Fix
Collapse both branches into a single
:is()—:where()keeps specificity at(0,1,0), so cascade is unchanged:For hover, emit as a CSS-in-JS object (not an
@media {...}string) so Tailwind reports compounds asStyleRules | AtRules, keepinggroup-hover:/peer-hover:composable.Known limitation
group-not-hover:/peer-not-hover:still don't compose — same architectural constraint that affects native Tailwind's owngroup-not-hover:.Test plan
not-*on every native-overlapping variant generates CSSgroup-hover:/peer-hover:/has-hover:unchanged semanticsgroup-not-disabled:,peer-not-disabled:,has-not-disabled:,not-group-hover:workrac-*) unchanged