fix(AIP-122): drop uuid disallowance in user-specified ID#1491
Merged
noahdietz merged 2 commits intoaip-dev:masterfrom Mar 13, 2025
Merged
fix(AIP-122): drop uuid disallowance in user-specified ID#1491noahdietz merged 2 commits intoaip-dev:masterfrom
noahdietz merged 2 commits intoaip-dev:masterfrom
Conversation
noahdietz
changed the title
slevenick
approved these changes
Mar 10, 2025
thall
added a commit
to einride/protoc-gen-go-aip-test
that referenced
this pull request
Jun 16, 2025
AP-122 specification states now that the user specified id can take the form of an UUID. https://google.aip.dev/122#disallowing-uuids-in-user-specified-ids aip-dev/google.aip.dev#1491
thall
added a commit
to einride/aip-go
that referenced
this pull request
Jun 16, 2025
Since this [PR](aip-dev/google.aip.dev#1491), usersettable id can now take the form of an UUID, this commit reflects that.
thall
added a commit
to einride/aip-go
that referenced
this pull request
Jun 16, 2025
Since this [PR](aip-dev/google.aip.dev#1491), usersettable id can now take the form of an UUID, this commit reflects that.
thall
added a commit
to einride/protoc-gen-go-aip-test
that referenced
this pull request
Jun 16, 2025
AP-122 specification states now that the user specified id can take the form of an UUID. https://google.aip.dev/122#disallowing-uuids-in-user-specified-ids aip-dev/google.aip.dev#1491
thall
added a commit
to einride/aip-go
that referenced
this pull request
Jun 16, 2025
Since this [PR](aip-dev/google.aip.dev#1491), usersettable id can now take the form of an UUID, this commit reflects that.
|
Hey, I think this is a good change. Reading AIP-122 it still says:
I was thinking about the "... the first character a letter" part. Is that something that should be revised now as well (given that uuids can start with numbers)? Thanks you. |
|
@slevenick sorry to ping you like this, but have you seen my question above ☝️ regarding the AIP-122? No rush, it would just be interesting to get your take on it. |
Contributor
|
Yeah, it would make sense to revise that guidance now that UUIDs are allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API designers have been asking why user-specified IDs shouldn't be allowed to be UUID, and there is no defensible rationale for doing so. Users should be able to provide whatever value they deem meaningful for their purposes, within the allowed character set and any API-specific restrictions.