docs: updates legacy pagination alternatives#1496
Merged
noahdietz merged 3 commits intoaip-dev:masterfrom Mar 28, 2025
Merged
Conversation
5 tasks
noahdietz
reviewed
Mar 25, 2025
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
noahdietz
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests an addition to the allowed criteria related to pagination to account for an existing legacy situation in the BigQuery library.
Namely, in legacy APIs, it authorizes the use of:
max_resultsas an alternative topage_sizefor identifying the maximum number of rows to returnUInt32Value,Int32Valueas well as the currently acceptedint32)For more details and discussion regarding this suggestion, see internal Google CL 736898880