Skip to content

docs: updates legacy pagination alternatives#1496

Merged
noahdietz merged 3 commits intoaip-dev:masterfrom
chalmerlowe:docs-pagination-update
Mar 28, 2025
Merged

docs: updates legacy pagination alternatives#1496
noahdietz merged 3 commits intoaip-dev:masterfrom
chalmerlowe:docs-pagination-update

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

This PR suggests an addition to the allowed criteria related to pagination to account for an existing legacy situation in the BigQuery library.

Namely, in legacy APIs, it authorizes the use of:

  • max_results as an alternative to page_size for identifying the maximum number of rows to return
  • the use of a broader subset of integer wrapper values (to include UInt32Value, Int32Value as well as the currently accepted int32)

For more details and discussion regarding this suggestion, see internal Google CL 736898880

@chalmerlowe chalmerlowe requested a review from a team as a code owner March 17, 2025 12:45
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread aip/client-libraries/4233.md Outdated
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
@chalmerlowe chalmerlowe requested a review from a team as a code owner March 28, 2025 11:30
@chalmerlowe chalmerlowe requested a review from itsStrobe March 28, 2025 11:30
@noahdietz noahdietz removed the request for review from itsStrobe March 28, 2025 14:21
@noahdietz noahdietz merged commit 46f6e7f into aip-dev:master Mar 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants