fix(AIP-158): clarify degraded skip response guidance#1510
Merged
noahdietz merged 6 commits intoaip-dev:masterfrom Jul 8, 2025
Merged
fix(AIP-158): clarify degraded skip response guidance#1510noahdietz merged 6 commits intoaip-dev:masterfrom
noahdietz merged 6 commits intoaip-dev:masterfrom
Conversation
noahdietz
requested review from
jskeet and
neomagus00
and removed request for
neomagus00
jskeet
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guidance for when
skipexceeded the collection size was a bit naive and needs more nuance. There are a number of reasons why askiprequest could not be fulfilled and the situation where it exceeds the the total size is a non-trivial one.This separates the guidance to give some flexibility for services to use the pagination interface to lead on the client as it attempts to fulfill the request, while also retaining the guidance for requests that the service knows exceeds the collection limit.