Skip to content

Updates AIP-140 and AIP-141 with guidance on naming quantity fields with compound and/or inverse units#1524

Merged
noahdietz merged 2 commits intoaip-dev:masterfrom
PeytonT:patch-5
Jun 10, 2025
Merged

Updates AIP-140 and AIP-141 with guidance on naming quantity fields with compound and/or inverse units#1524
noahdietz merged 2 commits intoaip-dev:masterfrom
PeytonT:patch-5

Conversation

@PeytonT
Copy link
Copy Markdown
Contributor

@PeytonT PeytonT commented Jun 9, 2025

No description provided.

PeytonT added 2 commits June 9, 2025 13:17
This includes a new subsection covering compound units, a new subsection covering inverse units, and some overall wording adjustments to clarify when plural form should be used for field names.
AIP-141 has been updated with more detailed guidance on the use of the preposition "per" in field names representing quantities, and this note should be updated to refer to that guidance.

Note that the previous note guidance here may have suggested that an event-frequency field should be named like e.g. "failures_per_hour", while after this change it will point to guidance in AIP-141 that specifies the format as e.g. "failure_count_per_hour". This may be interpreted as a functional change.
@PeytonT PeytonT requested a review from a team as a code owner June 9, 2025 20:36
@PeytonT PeytonT requested a review from noahdietz June 9, 2025 20:36
Copy link
Copy Markdown
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thank you @PeytonT

@noahdietz noahdietz merged commit e96e08c into aip-dev:master Jun 10, 2025
2 checks passed
Copy link
Copy Markdown

@saeedzaha saeedzaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants